Multiselect produces invalid HTML

[nickvergessen]

Ref https://github.com/nextcloud/spreed/issues/7651

Error: Bad value for attribute name on element input: Must not be empty.

This was brought in upstream: https://github.com/shentao/vue-multiselect/blob/2.1.6/src/Multiselect.vue#L157-L165

But is not named or piped through by the Vue lib.

Fixable with a patch in Talk just adding something like:

name="default_group_notification"

• [ ] Maybe we should add this as required prop or fall back to the id value?

---

Error: Bad value nope for attribute autocomplete on element input: The string nope is not a valid autofill field name.

https://github.com/shentao/vue-multiselect/blob/2.1.6/src/Multiselect.vue#L51

Upstream issue again, but changed to off in master: https://github.com/shentao/vue-multiselect/pull/1064

But there was no release since: https://github.com/shentao/vue-multiselect/issues/1518

---

Error: Element div not allowed as child of element span in this context. (Suppressing further errors from this subtree.)

Comes from https://github.com/nextcloud/nextcloud-vue/blob/a08bfb147a970a34abd0881ecd305f5f78b699cc/src/components/Multiselect/EllipsisedOption.vue#L24

So would need someone to look into it and transform it to a span or something.

• [x] #2895

[nickvergessen]

@PVince81 any opinion on first and second Error?

[PVince81]

no idea where that "nope" comes from. replace with "off" ? https://rocketvalidator.com/html-validation/bad-value-nope-for-attribute-autocomplete-on-element-input-the-string-nope-is-not-a-valid-autofill-field-name

[nickvergessen]

As mentioned it's the lib, off is in there master, but it's not overwritable? So if they don't release we have to switch to another lib

[nickvergessen]

Seems to be fixed now, at least talk validation passes