Nick Telford

Results 12 comments of Nick Telford

Just wanted to add that this would also make the network module useful for tracking other kinds of ephemeral network connections, in particular: tunnels/VPNs

Unless I'm mistaken, this invokes the copy-constructor of `ColumnFamilyDescriptor`: ```c++ *desc = ColumnFamilyDescriptor(cfd()->GetName(), cfd()->GetLatestCFOptions()); ```

Good point, although it looks like the `ColumnFamilyOptions` within that descriptor is copied into the Java `ColumnFamilyDescriptor`, here: ```c++ static jobject construct(JNIEnv* env, ColumnFamilyDescriptor* cfd) { jbyteArray jcf_name = JniUtil::copyBytes(env,...

> I can see a few possible options: > > 1. We could perhaps have `ColumnFamilyDescriptor` extend `AutoCloseable` and implement `ColumnFamilyDescriptor#close()` as: > > ```java > @Override > public void...

Note: this is part of KIP-892 Transactional StateStores. It introduces a new config option that will have no effect until the rest of KIP-892 lands at a later date. @cadonna...

@cadonna @ableegoldman Is there any more we need to do with this PR before we can merge it?

See the attached flame graph, which demonstrates the memory being allocated and copied by `StringBuilder.append()` under `recordBean`. Note: I'm pretty sure the JVM is inlining `Receiver#defaultExport` into `JmxCollector#recordBean`, which is...

I'm no longer convinced that the lack of estimating `StringBuilder` size is the main reason for all these copies. When `StringBuilder` expands, it always at least doubles its current size,...

@dhoard I had a feeling that would be the response, which is why I raised this as a discussion rather than a PR. I'm curious, do you have evidence that...

Fair point. How about we create two Maven profiles, one for targeting JFK 8, and one to target JDK 9, then release multiple artifacts? Shouldn't be too difficult to sort...