Nick Snyder

Results 88 comments of Nick Snyder

I am not sure where the misunderstanding is here. All the files you list are input files. They will be parsed according to their file extension, so you can mix...

@AttilaTheFun I played around with using SizeLayout with Alignment.aspectFit and realized that it doesn't quite do what you want. Your AspectLayout looks pretty close to mergeable. Want to submit a...

Lgtm based on reading doc. Any downsides?

Data from #63 suggests that this is probably worth doing from a performance perspective.

I don’t have any concerns

@ghmake1y Does the test you added fail without your change?

Yeah, this looks like a bug. That said, I was not able to reproduce it in a playground: ![image](https://user-images.githubusercontent.com/754768/36083294-b58db1d4-0f65-11e8-8c22-24c1398aebc2.png) ```swift import UIKit import PlaygroundSupport import LayoutKit let iconLayout = SizeLayout(width:...

It does regenerate all arrangements. Now that BatchUpdates is a parameter (it wasn't initially), it would be possible to do the optimization you suggest. This optimization can only be done...

I can reproduce this issue using Safari 10.0.1 on El Capitan. Since Firefox and Chrome don't appear to have this problem, I would bet that this is just a bug...