Nicholas Orlowsky

Results 8 comments of Nicholas Orlowsky

> Hi @nickorlow , > > Thanks for this. > > Please explore contributing tests for this. Particularly e2e tests. > > regards Should we include the tests in this...

Hey @Preetham777 ill look into this today. Thank you for finding it!

@Preetham777 just pushed a fix. Have yet to test it (writing the e2e tests for it right now) but I believe this should resolve your issue.

> i dont think our kind e2e tests use cgroup v2 so none of our e2e tests will hit the new code paths. > > How are we certain this...

> Any news about this PR? Just fixed the formatting issue. Would appreciate input on what to do with the e2e tests regarding my last comment (or if we should...

Added e2e tests. I made it so that the cgroups files are created during the test so they're not somewhere else in the test config and also we can test...

> @nickorlow @tao12345666333 Looks like this is stalled/forgotten? I think so.. anything more I need to do to have this merged? I believe all requested changes have been made

@tao12345666333 Everything updated. Had to make some changes to the tests since docker mounts the cgroup directory as ro unless you run it in privileged mode.