Nick Partridge

Results 142 comments of Nick Partridge
trafficstars

Interesting that's pretty similar to mine. Let me know if it still gives you trouble and I can try running it on mine from scratch.

Ok I'm afk but I'll try it tomorrow and let you know.

Ok I removed all references to `puppeteer` used in old visual testings and `canvas` used in jest tests, both shouldn't affect playwright tests. I pushed changes to [`elastic/elastic-charts#buildkite-arch-test`](https://github.com/elastic/elastic-charts/tree/buildkite-arch-test). Since you...

No not _really_ 😞 We tried everything in the book to make it work to where we could update screenshots locally on either `arm64` or `amd64` CPU architecture, interchangeably. Regardless...

@aslushnikov Thank you for the incredibly detailed review of this! --- > Realistically, though, the anti-aliasing differences are not important for the visual regression testing use cases. So with this,...

Please keep this issue open. This is the only practical way of interacting with renovate bot to debug blocked or errored PRs or to trigger a full run on the...

I'll take a look, but the file diffs are determined on the entire pull request, see request below. In any case I'll take a look and see what's going on....

Yeah, we wrap the `Chart` component in an `ErrorBoundary` to prevent the chart from erroring to the parent. I think the `onError` idea is a great idea. https://github.com/elastic/elastic-charts/blob/35bb737b7c5031a8b64b68eb85720bbe3f033df6/packages/charts/src/components/chart.tsx#L171-L176 Eventually, I'd...

We also have the idea of a `GracefulError` see https://github.com/elastic/elastic-charts/pull/779. Another approach it to have an option to propagate errors allowing the use of an `ErrorBoundary`, otherwise we catch all...

> I'm looking to do the same, but I'm a little confused as to how this works with each shard outputting an html report with the same name/filepath. Is each...