Nick Partridge

Results 141 comments of Nick Partridge

@vinaychandrasekhar the main issue, seems to me, is requesting a toggle for all annotations. Is this your expectation too? Or is your request to toggle each annotation individually? If so...

Ah got it, so the annotations grouping as a whole is only toggleable via the legend. I think https://github.com/elastic/elastic-charts/issues/555 will cover you use case but I added a requirement to...

Thanks @mbondyra, I recently tweaked our spec wrapper and noticed this in some snapshots. I'll look into this soon.

What do you think about adopting a `child`/`parent` structure for the tooltip and legend info? This would replace the `path` property that conveys the same context. Then the children array...

@flash1293 Nope you are correct, I am working on adding support for the `customTooltip` option.

Since we only add a `mouseMove` listener to the chart container component here... https://github.com/elastic/elastic-charts/blob/60a14ba87f3f63910df9aa99312dfe4b8d6ce847/packages/charts/src/components/chart_container.tsx#L181-L194 I am thinking this would require us to add a global event listener to the `window`....

AFAIR this is intentional https://github.com/elastic/elastic-charts/pull/1204

Thanks for the thorough response. I think we table this discussion for now and revisit it in the future.

What if instead of using a custom reconciler we switch to a json config style api instead of a react component api? Just thinking out-loud. This has the following benefits...

> the JSON config doesn't preclude the ability to have a react bridge That's true, but to Robert's point it does inherently create constraints, in addition to rework. > my...