Nick Hammond

Results 75 comments of Nick Hammond

I've updated this with the latest from main. I've been using this branch to deploy a few projects for a few months now and haven't had any issues. Let me...

The test matrix run for Ruby 3.4.0-preview2 with the current Gemfile is failing for some reason, it's working fine with the same version and the Rails edge gemfile. It's passing...

@djmb No worries, enjoy your time off next week! Ideally https://github.com/buildpacks/pack/issues/2268 that @edmorley opened gets merged in so we don't have to inject the image-labels pack but that looks like...

The Paketo buildpack CLI also recommends adding labels via the image labels buildpack so we might just want to leave the labelling as-is. https://paketo.io/docs/howto/configuration/#applying-custom-labels

@djmb Are there any tests or verification steps that I can add to make this easier for you to review? I'm using this branch to deploy 5 different apps now,...

@djmb Sounds good, I'll take a look at the kamal-site docs PR again as well this week.

@djmb I updated all of the demo apps and redeployed with the latest using this branch, all went well. The build context was removed `"."` and there's no longer a...

@gregjotau It looks like you've defined a builder but you also need a buildpack. I haven't built a spring app but this looks like the one mentioned in the Spring...

Should we `freeze` the existing constant(`CONTAINER_NAME`) too?

@igor-alexandrov oh that’s lovely, good to know.