Reuse CONTAINER_NAME constant

Open igor-alexandrov opened this issue 1 year ago • 4 comments

This PR reuses existing CONTAINER_NAME constant value instead of duplicating container name in a string.

Sep 26 '24 05:09 igor-alexandrov

Should we freeze the existing constant(CONTAINER_NAME) too?

Sep 26 '24 11:09 nickhammond

I followed the conventions for other constants in the code base, they are not frozen. Also, starting from Ruby 3.4 strings will be frozen by default, so I don't think this is needed.

Sep 26 '24 12:09 igor-alexandrov

@igor-alexandrov oh that’s lovely, good to know.

Sep 26 '24 13:09 nickhammond

This has been rebased.

Oct 09 '24 09:10 igor-alexandrov

Closing this as the constant was removed at some point

Dec 01 '25 08:12 djmb