Nicholas Bishop

Results 123 comments of Nicholas Bishop

UEFI variables can hold arbitrary data, so there's no single optimal way to print them. `BootOrder` is described in [section 3.3](https://uefi.org/specs/UEFI/2.10/03_Boot_Manager.html#globally-defined-variables): > The BootOrder variable contains an array of UINT16...

> Any suggestion where to put the code? A new module altogether? As part of a new EfiLoadOption type? Perhaps with a new EfiLoadOption::try_from() trait implementation? If possible, I'd like...

I'm not sure about the iterator. It's possible that kind of logic might be too specific to the application using it, so even if we provided it, bootloaders might end...

I had to ponder this a bit :) It is possible to do with the current API, and I've put up a PR to demonstrate this in the test-runner: https://github.com/rust-osdev/uefi-rs/pull/931...

I'm cautiously in favor of this proposal. We did something along these lines in https://github.com/rust-osdev/uefi-rs/pull/478, where we added a [global image handle](https://github.com/rust-osdev/uefi-rs/pull/478/commits/9a70c90700d9751a30c492872ac2bd2b3cef0da1) that gets set automatically by the `entry` macro....

Expanding on downside 1 from my list above with a related problem: Structs that currently have a lifetime tied to BootServices (like `ScopedProtocol` and various others) presumably wouldn't have that...

I've been playing around with this a bit, to get an idea of what it would look like in practice. I put up what I have for discussion: https://github.com/rust-osdev/uefi-rs/pull/905 A...

A few more thoughts in favor of adding global pointers: * The new support in rust-lang for enabling `std` on the UEFI targets uses global atomic pointers: https://github.com/rust-lang/rust/blob/f654229c27267334023a22233795b88b75fc340e/library/std/src/os/uefi/env.rs#L8 * As...

Was this closed intentionally?

Makes sense. Is the `compiler-builtins-no-f16-f128` feature still needed here? I'm unclear whether that mangling error was the only problem, or if it's still correct to turn off f16/f128 for gcc/cranelift.