Nicholas Bishop comments

Results 123 comments of


                                            Nicholas Bishop

IDE issues

Finally got around to taking a look at this. I don't have much in the way of solutions, but here are some notes for future travelers: For my test case,...

Add an mdBook

> I'm a little concerned that this will lead to inconsistencies between the documentation from the code and the mdBook over time. Definitely good to think about how we will...

Add an mdBook

@phil-opp that sounds great. How about `rust-osdev.com/uefi-book` as the URL redirecting to https://rust-osdev.github.io/uefi-rs/HEAD/

Change `Event` to be FFI-safe using `NonNull`

I agree that it should be mentioned in the changelog.

Change `Event` to be FFI-safe using `NonNull`

Merged, thanks for the PR!

rustdoc cleanup: use rustdoc attribute

Thinking through some tradeoffs and possibilities for nightly MSRV: 1. I think for nice-to-have changes that require a nightly MSRV bump, we could just pick some kinda arbitrary not-too-short, not-too-long...

rustdoc cleanup: use rustdoc attribute

Oops, missed that question before. I added a `needs-msrv-bump` label for this PR and another new PR.

CI is broken: "GlobalValue with DLLImport Storage is dso_local!"

Thanks for filing that bug, confirmed that the PR you identified seems to be causing the breakage. I left a comment with details of what I ran to bisect.

Remove use of `-Zbuild-std` if and when the UEFI targets become tier-2

From https://github.com/rust-osdev/uefi-rs/pull/502#discussion_r963099960: We should also add a `targets` field in `rust-toolchain.toml` listing all the required targets. (This isn't very well documented in https://rust-lang.github.io/rustup/overrides.html as yet. Note that this is different...