nibon7

Results 33 comments of nibon7

Seems channel issue introduced by 91e17d2f9, I reverted it, and it doesn't hang again. Related #5625

> Is this option available with your change? Nope. This PR always render the right prompt on the last row. Shall we provide an option to render it on the...

> My personal preference would be like the middle one in #4909. I think you must have disabled `add_newline` :joy:

I have a base implementation to control whether we render the right prompt on the first or last line by setting an environment variable. @fdncred ![Screenshot from 2022-10-16 21-11-23](https://user-images.githubusercontent.com/15247421/196037294-9f8941f9-66da-4fdc-8ba1-472dd46c34e0.png)

> Will the right prompt still be hidden when the first line is full? In fact, we just calculate the width of the last row, so if there are multiple...

> I do think this should be some configurable option in nushell vs an env var maybe? Agreed, I did this just for a quick test.

I think the tests should cover all the changes :)

> So, if I understand this properly, the idea of `select -i` is to fail silently, correct? exactly. > I don't think "replace them with nothing" is right now. I...

Thanks, I'll fix it.

> don't think we want to have any side effects in the expressions Thanks for pointing it out, I didn't realized it :joy: > if you create a new version...