Nickolay Olshevsky

Results 234 comments of Nickolay Olshevsky

@antonsviridenko Yeah, but it uses gpgme which invokes gnupg executable. Also it would restrict user to the LGPL license.

> How language bindings (py-rnp, ruby-rnp, swift-rnp) are synchronized with RNP API updates? Manually :) There is no any formal process yet. Probably we should make one, or add some...

@antonsviridenko In web server context I see only two ways - via some callback (is it possible for PHP?), or via string constant. The second option however would need to...

@antonsviridenko ruby-rnp uses callback or predefined password approach, please see this example: https://github.com/rnpgp/ruby-rnp/blob/main/examples/password_provider.rb

@antonsviridenko I'm fine with proposed changes, let's switch to HEAD.

I see the following duplications: - redundant coverage tests. With the same backend coverage report should be the same independent on OS. I.e. run only one coverage job on centos...

Strange since `ffi_pass_callback_file` is defined correctly: ``` static bool ffi_pass_callback_file(rnp_ffi_t ffi, void * app_ctx, rnp_key_handle_t key, const char * pgp_context, char buf[], size_t buf_len) ```

This could be false positive, as the issue with stdout_writer, see PR #1709. Possible solution: ``` #if defined(__clang__) __attribute__((no_sanitize("undefined"))) #endif ```

@ronaldtse CentOS 7 has EOL 2024, while 8 had end of 2021, is it okay to drop 2-year support timeline? Also, then should not we add support for CentOS stream...

Oh, I forgot - we already use CentOS 8 Stream images in CI, but those are unofficial (there are no official on the Docker hub, they use Quay). Will file...