Nickolay Olshevsky

Results 229 comments of Nickolay Olshevsky

> ...whether the implementation of this draft would be relevant to RNP from their perspective For me this draft seem to be in a quite early stage, and I don't...

@falko-strenzke Yeah, Botan head introduced changes to FFI aead handling, which is not compatible with our understanding of how it should work :) I'm working on a fix. Sure, I'll...

@falko-strenzke sorry, I postponed this because of the issue on vcpkg side, which causes CI to fail (and we cannot merge with failing CI): https://github.com/microsoft/vcpkg/issues/40276 Was trying to workaround it...

@TJ-91 No worries, it's codecov who bothers, not you :) At some point I spent a while trying to understand it's behaviour and it's actually quite simple. The coverage decrease...

Having two approvals let's finally merge this. Thanks all!

I don't see strong need for this right now as user may manually implement signer choosing logic (and what Thunderbird as a major RNP user does now).

> A user might have chosen to start a process of phasing out an older key, but it might be still valid. And the user has a newer key, which...

This is definitely an error in logging code, however it may only happen if ENABLE_PQC_DBG_LOG is defined. Why do you need it, given that it's just a debug output of...