Nickolay Olshevsky

Results 208 comments of Nickolay Olshevsky

Okay, looks like I just wasted time trying to fix codecov/project CI check. So let's finally make a release.

Thanks all, let's make a release!

Version 11.0 should be used, pre-commit hook should be fixed to v11.0.

> We should probably migrate all the pre-commit hooks into CI hooks. > To be honest I never used pre-commit hook and run clang-format manually via VS Code build tasks....

@maxirmx in my workflow it was easier and more clean (no clang-format dedicated commits) to configure clang-format job in VS Code, and then, in case of need, run it and...

@falko-strenzke @TJ-91 JFYI, this includes CI run for PQC stuff, got some memory leaks fixed in tests via the latest commit.

Two approvals and green CI, so merging. Thanks all!

Hi @aeris, Thanks for reporting this issue. We'll include the fix to the v0.17.1 release which is about to happen.

@kaie That's because self-signatures on the key contains wrong lbits value (forced to 0x0001), which by RFC 4880 is `- Two-octet field holding the left 16 bits of the signed...

> Is it correct to reject this key, or is that a bug in RNP? It's not a bug but decision (which could be changed in case of need) as...