Neil Horman

Results 475 comments of Neil Horman

yeah, this is currently just some experimentation in pursuit of https://github.com/openssl/project/issues/853 The goals as I understand it are: 1) Accelerate build time 2) Make build time results visible on a...

FWIW, i don't see anything expressly wrong with the changes, its fine to call OPENSSL_init_crypto in your application rather than having the library do it as needed, but I'm having...

Thank you. Thats interesting, I just tried to recreate with the head of the master branch, and didn't encounter the leak. Given that you reported the issue was introduced with...

hmm, what version of valgrind are you using? I'm on valgrind-3.23.0

also, what does your openssl.conf look like? Its possible I'm not loading any modules, and as such not triggering the allocation thats leaking

In fact, I'm sure its my config, I just ran it through gdb and never hit a breakpoint in ossl_rcu_read_lock

There we go, if I load the oqs provider (duh, should have thought of that), I see the leak. Now to figure out why

Ok, think I found the problem. https://github.com/openssl/openssl/commit/83efcfdfa1de760bd30df7f4cf94e7a0d2b0db9f added a use of ossl_init_thread_start to the code base, for which there is only a handful of users. ossl_init_thread_start registers a handler function...

It's a bit late here now, but I'll take a look in the am and let you know

@ashman-p do you have a particular signature algorithm that you see as not encountering the leak? I'm looking at the available defined SIG algs and I don't see any available...