Neil Horman

Results 475 comments of Neil Horman

@tom-cosgrove-arm can you comment on the fix you made in #23757? I'm having trouble seeing how a fake tag can be used with aes in ccm or gcm mode? I...

@ravulapx it seems like the consensus here is that the appropriate fix is, for gcm mode speed tests: - [ ] Modify the speed_main function such that, when loopfunction is...

@tom-cosgrove-arm your solution would certainly work. I guess the question is "is it ok for us to test algorithm speed on failing inputs"? If so, that would be a faster...

@ravulapx are you interested in attempting to write a patch for this and submit it as a pull request, guided by the conversation above?

I'm not sure I follow, The thread_event_handler is cleaned up in context_deinit_objs is called during context teardown. What did AppVerifier show you?

The individual thread context objects should be deallocated when the threads that allocated them exit, or when the library context that allocated that correspond to them are freed. The fact...

I believe that the ordering of the last two calls is the problem. I'm not 100% sure, and its a bit counter-intuitive, but freeing the libctx that you've allocated call...

It seems this is just waiting on a last minor [doc nit](https://github.com/openssl/openssl/pull/22980#discussion_r1429692315). given that this has sat idle for 250 days, is there any reason we can't just fix up...

added to tracking

The first question I would ask is, why are the read and write fds in the read and write set not readable/writeable? This suggests that something wen't wrong with the...