Neil Horman

Results 475 comments of Neil Horman

hmm, nothing has changed in that code in quite some time. If you revert the commit you identified, do the tests pass?

I ask because 16a64b0 just added a check to disable ipv6 tests if openssl was built with OPENSSL_USE_IPV6=0. I'm wondering if that change didn't inadvertently impact the timezone settings on...

@mattcaswell , can you comment here please?

@mattcaswell I think adding a version prefix to the key would be the less confusing way to go, then each installation would just use their respective key. Ostensibly if someone...

ok, Significant refactoring, We now have the ability to define -DWININSTALLCONTEXT at build time, which lets us create values in the HKLM\SOFTWARE\OpenSSL-- key path in the registry, from which we...

ok, to the not falling back comment. Re the define, OPENSSL_WINIINSTALLCONTEXT seems agressively long for a build time define. OPENSSL_WINCTX maybe? Also, my favoirite bikeshed color is green. It has...

wait, actually, if we don't fall back to build time defaults, are we at risk of breaking existing installations on upgrade? i.e. if a user explicitly built openssl on windows...