Nick Graef

Results 39 comments of Nick Graef

Can I ask why `resolve` publishes the `test` directory in its package in the first place? In my opinion, `test/` should be in `.npmignore`. I found this issue because I...

> because `npm explore foo && npm install && npm test` should always work. I don't agree with that statement, because in many cases it would require publishing nearly the...

Also requested in https://github.com/replicatedhq/dockerfilelint/pull/154#issuecomment-729961410 and https://github.com/replicatedhq/dockerfilelint/pull/151#issuecomment-777889046. @marccampbell Would you mind weighing in here? There are a couple great fixes waiting to be released to npm.

This was partially completed in #89. #88 adds some pieces that were missed.

This was still a problem the last time I checked. However, I no longer use moleculer, so I can't say definitively for the latest version.

> FYI I noticed that it fails when I'm not connected to the company VPN. After connecting to the VPN it can start successfully. That is what my team noticed...

@nikpivkin I notice you changed the reproduction steps to include installing the dependencies in a fresh project. That won't work out of the box because newer patch versions of `fsevents`...

_Repost from https://github.com/aquasecurity/trivy/discussions/5134#discussioncomment-6930978_ > This patch in [`aquasecurity/go-dep-parser`](https://github.com/aquasecurity/go-dep-parser/blob/6931c9a35c47f106fc3bffed6a44ba6bcfdcd588/pkg/nodejs/npm/parse.go#L118) fixes my use case: > > ```patch > diff --git a/pkg/nodejs/npm/parse.go b/pkg/nodejs/npm/parse.go > --- a/pkg/nodejs/npm/parse.go > +++ b/pkg/nodejs/npm/parse.go > @@ -116,6 +117,7...

This would be nice as a built-in feature. I currently have it implemented as a PR check in a fairly simple pipeline using multiple scans: 1. Checkout base branch in...