Nathan Goldbaum
Nathan Goldbaum
Except I don't have triage rights in this repo, so maybe @rgommers can do that.
No this isn't done yet. I'm waiting on a PyO3 and rust-numpy 0.24 release before I can start working on kornia-rs.
I updated the pyo3 and rust-numpy dependencies to 0.24.0 and it looks like the existing tests pass: ``` (kornia-py) goldbaum@goldbaum-QEMU-Virtual-Machine:~/kornia-rs/kornia-py$ PYTHON_GIL=0 pytest ============================================================= test session starts ============================================================= platform linux --...
> Yes, please go ahead with the PR. Awesome, I'll work on that today. > About PyTorch, not sure I understand, as we are just downloading prebuilt wheels. PyTorch only...
I audited the python bindings for thread safety today and it looks like things are in pretty good shape, at least for `kornia-rs`. The `kornia` Python library is likely susceptible...
After #320, the only `unsafe impl` left in the codebase is for `TensorStorage`: ``` crates/kornia-tensor/src/storage.rs 129:unsafe impl Send for TensorStorage {} 130:unsafe impl Sync for TensorStorage {} ``` This type...
> do you have any suggestion for it ? that's the only workaround I could find at that time It's fine as-is, IMO. That said, I'm not sure the `Arc`...
In the meantime I think I might send in a PR adding thread safety docs and declaring free-threaded support in the extension module. I don't think multithreaded stress tests are...
cool, I’ll try messing around with that PR branch sometime in the next few days.
not sure I can - want to give me a `kornia-rs` commit bit?