Nikola Forró

Results 84 comments of Nikola Forró

Related issue: https://github.com/packit/packit-service/issues/1284

Could be also related to https://github.com/packit/deployment/issues/548.

> From arch discussion: let's try to check Pagure code and whether we could add the missing info - indicator if the push originated from merged PR I thought about...

Yes, checking PR state won't help but checking its target branch should as we know the branch to which the commits are being pushed. > From arch discussion: let's try...

If there are two PRs with the same head commit targeting the same branch then the problem persists. But such scenario is very unlikely, isn't it? What we could do...

Good point. I think the only reliable way to solve this is to include (potential) PR metadata in the push event, so there is no need for guessing on Packit...

> So that approach would involve updating the pagure repo right? Pagure source code, to be specific. > Wouldn't it still have the same potential race condition? What race condition...

> My thought on this was to replace the trigger, i.e.: > > * `pagure.pull-request.closed` listener: checks `koji_build` for PR triggers with `allow_pr_authors`, label filters, etc. > * `pagure.git.receive` listener:...

> Or would it still be triggered by any push to the branch, but you would internally look for the PR that matches it? It shouldn't be necessary to look...

Pagure PR: https://pagure.io/pagure/pull-request/5452