Nikola Forró

In my opinion we should deprecate `build`, it's too ambiguous, and I like `scratch_koji_build` better than just `scratch_build`. I feel if we used `upstream_koji_build` we should also rename `copr_build` to...

> Regarding the `upstream_koji_build`, I like it more than `scratch_build`, it seems to me more consistent to have `koji_build` and `upstream_koji_build`. Or also `koji_scratch_build` would make sense, but on the...

I've updated `PackitRepositoryBase.download_remote_sources()` to raise `PackitDownloadFailedException` on download failure (related to https://github.com/packit/packit-service/issues/1608) and to ignore failed downloads from lookaside cache (to preserve rebase-helper behavior).

I'd appreciate another look, since I introduced some changes, thanks :slightly_smiling_face:

> @nforro , how does this code changes after switching to the Specfile library? It looks like this: https://github.com/packit/packit/pull/1588/files#diff-ac08f991727986725346bab74cee3c2c87cd6cf7c65b99e8f375608db7e7ee22R462-R474 ```python # Fetch all remote sources defined in the spec file...

Are we talking about this spec? https://gitlab.com/fedora/legal/fedora-license-data/-/blob/9adbc9079485e80b8e25293787ccb975a8715ec4/fedora-license-data.spec If so, the problem is missing `sources` file, without it it's not possible to download the tarball from lookaside cache.

> @nforro Does the `sources` file need to be already committed in dist-git to use LookasideCache? Or, do we work with a local directory with the dist-git content? (If adding...

> For context, in this state of the Packit's workflow, the source is most probably not present in the cache -- actually, as a next step, we upload the archive...

> But there is (was) neither no `sources` nor sources in lookaside cache. We are speaking about the very first propose-downstream to completely clean dist-git. Yes, but missing `sources` together...

Possibly, but I don't think there is any support for MacOS at all currently, even though there seems to be an interest: https://github.com/junaruga/rpm-py-installer/issues/155