Nico Flaig

Results 422 comments of Nico Flaig

> it might still be woth doing for the following reasons: Looking at some examples in our code https://github.com/ChainSafe/lodestar/blob/c4bf38576e0cba5880697de3a5ca4956162ede5e/packages/api/src/utils/server/genericJsonServer.ts#L1 It does not look like it make any difference as tsc...

> Not directly a sim test error, but somewhat related: [Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the...

Sim merge tests keep getting stuck and time out after 6h since we merged https://github.com/ChainSafe/lodestar/pull/6344 (as I noted already in the PR), see recent runs on unstable branch ([1](https://github.com/ChainSafe/lodestar/actions/runs/8056718705/job/22006366528#step:15:6025), [2](https://github.com/ChainSafe/lodestar/actions/runs/8051995847/job/21991162221#step:15:6021)).

The browser tests keep failing due to different reasons, this one looks like a race condition ([failed run](https://github.com/ChainSafe/lodestar/actions/runs/8589475783/job/23536119752?pr=6648#step:6:94))? The file has a test suite defined and it passes most of...

> [test/unit/utils/clock.test.ts > util / Clock > getCurrentSlot > 'should return next slot after 11.5s'](https://github.com/ChainSafe/lodestar/actions/runs/7652507863/job/20852823580#step:6:714) Interestingly I have not seen that one in a while, maybe related to updating vitest?...

Sim merge tests seem to be stuck, running for almost 3 hours already

I assigned the issue to you @mabsattar, feel free to join us [on discord](https://discord.gg/KCHpWsKT) in the #lodestar-developer channel

Would be good to address this before Deneb on mainnet

Updating test data here should fix this https://github.com/ChainSafe/lodestar/blob/53378e1e08f5947bfe119c07c9b8211117f34cd9/packages/api/test/unit/beacon/testData/events.ts#L52-L57

> It's not yet clear what the best fix would be. Let's just make the spec example address all lowercase?