Nate Fischer
Nate Fischer
Yeah, I see those benefits. On the other side, here are the drawbacks to keeping it in the same repo: - If external developers contribute to shelljs, they also have...
Would it be possible to add an extra CI run of our test suite to compile everything with `tsc` and run the tests? I would expect `tsc` to be a...
I'm not objecting to this, I'm not sure what response you were waiting for. Steps for implementation: 1. Provide support for typescript by running our CI under `tsc`. 2. Move...
@Strum355 I'm in favor of bringing typings into shelljs itself, but I need help setting up our infrastructure to actually test that code. Like I've said, I'm not a typescript...
@natepisarski I'm open to reviewing a PR. That said, after looking at the [definitelytyped repo](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7fbbde824a8a07f2b998e2ee1885f7611e34f7aa/types/shelljs/index.d.ts), I see some mistakes (e.g., `cp()` returns a `ShellString`, not a `void`). I'll accept typings...
We don't maintain those definitions currently. We're discussing moving them into this repository (#736)
> I don't know if ava has a way to do this globally for every test. @freitagbr Huh? `beforeEach()` does run before every test, as-is. What did you mean?
I'll write up a PR in the next couple days.
> But that's fine, it's not a big deal if each test file has beforeEach in it. Some test suites have different requirements from others. For example, some require a...
Another thing (caught this in #874), we should robustly set `process.env` to its original value (resetting each property). This should happen in `afterEach.always`.