Nate Fischer
Nate Fischer
The only spot we execute `node` is via `execFileSync()`: https://github.com/shelljs/shelljs/blob/12b8c4864ffc7a1c3a2dbf8cfd888fb62d373120/src/exec.js#L81-L83 I don't think we need to quote parameters for this, so I don't see why we're getting this error. We...
Hmm, it works if I use: ```js shelljs.ln('-s', '/some/source/path', 'nameForLink'); ``` It looks like `ln` should behave like `cp`: if the last argument is an existing-directory, then the link should...
> is actually the basename from the user-provided source path. Seems reasonable. `ln -s` is kind of funky in that respect.
You need to use `/regex/g`, not `/regex/`. This is working as intended, but I realized the documentation is poor. I'm open to documentation suggestions.
To clarify, this should be limited to only our tests (because those use ES6). Once we drop support for node 4/5, we can expand this to cover the whole source...
@blubrick yes, please file a separate issue. I'm happy to take a look at the report (and would also appreciate PRs to update flagged packages if doing so does not...
> Do you think I should raise this as a separate issue? Filed as #969
This doesn't seem to be globbing specific. I think `sed()` is just adding a newline to the end each file (except the final one). Is this the same root cause...
The array idea looks great! You're right, order does matter, so we'll need to incorporate arrays at least at the top level. We need to make sure we handle redirects...
Passing this off to @freitagbr to finalize the design.