Nick Irvine

On(*, func) seems to indicate that you can have the socket passed as an arg, but this is not explained anywhere?

1

https://github.com/googollee/go-socket.io/blob/b14926c0af346c1ec2ac75cfb74acad2e48b3a69/caller.go#L31-L34 makes it look like you could do something like: ``` go so.On("message", func(Socket socketio.Socket) { // so == Socket }) ``` But this is undocumented.

When passed a DNS name, InitiateConnection only resolves one record; all records would be better

1

https://github.com/weaveworks/mesh/blob/master/connection_maker.go#L96 If the `host` part of a `peer` is a DNS name, it'd be nice if that name were resolved and *all* resultant addresses were added to the list, instead...

`user` in a CopySpec overrides task-level `user`, contrary to documentation

2

Repro: ```... task buildRpmBroken(type: Rpm) { release '1' version '0' os = LINUX arch = 'noarch' type = BINARY packageName 'nebula-rpm-repro-broken' user = 'root' permissionGroup = 'root' into ('/tmp/broken') {...

Ensure repo is managed before package installation

1

Fixes #56 (My puppetry isn't great, so please triple check

Otherwise, yum may attempt to install before the repo is configured. I'm cooking a PR.

xfce terminal support for solarized is baked into xfce4-terminal now; it should be removed?

4

http://git.xfce.org/apps/xfce4-terminal/commit/colorschemes/solarized-light.theme.in?id=0aab08157c72b4b76587cf89f8d4f1f235f2da24 Especially considering upstream is unmaintained: https://github.com/sgerrand/xfce4-terminal-colors-solarized/issues/11