F. E Noel Nfebe
F. E Noel Nfebe
Looking at https://github.com/nextcloud/spreed/blob/978922ee73e74f15c2ffe3fd83800edb6d2b01af/tests/integration/features/bootstrap/FeatureContext.php#L2452-L2459 it does look like we expect the user to type the search query to include the room? according to regex `'/conversation:ROOM\((?P\w+)\)`? Or at least that we need...
The URL's being sent look like `/search/providers/talk-message/search?term=uni&from=/apps/spreed/&conversation=qbhbdutu` @nickvergessen kindly test and review at your earliest convenience. Thank you.
> Seems to be working after compiling locally (because you didn't commit that yet). > > > > The "In conversation" should be moved further up so it is grouped...
@nickvergessen PS, had time to read my comments?
> Integer, just like with the normal providers on the PHP api It is sure an int, but the chosen integer if being set from the front-end needs to be...
> Ah you don't have the priority in the frontend, the backend sorts it and does not expose it. > > I guess that sounds like the best option then...
> Outside of cases where to make the code clearer and more maintainable for the future, good PR :) Discussed with others, and the API deprecation can be handled later,...
Additionally, when creating a new share, if the set expiration date is unchecked, the expiration date is set anyways.