F. E Noel Nfebe

Results 89 comments of F. E Noel Nfebe

> I do not thing that this fixes https://github.com/nextcloud/server/issues/37424 but it's an important and appreciated code cleanup +1 Definitely, it does not. I want to address that in a separate...

So after setting a `Psr` compliant logger in `index.php` it appears to me like the only way to write to the log file is to use one of these methods...

Update (now fixed) --- I added the commit : ``` Avoid making db connection when logging about database connection For various reasons, sometimes a database would not be possible. Our...

@kesselb Sorry for the delayed response the function that does this is `logDetailsAsJSON`. See : https://github.com/nextcloud/server/blob/master/lib/private/Log/LogDetails.php

> The above line causes the issue. getAppVersions requires a working database connection to fetch the app versions. The function is called in the memcache factory :( Thank you @kesselb...

> Now the problem is that this silently ignore an error. I would feel better if I understood why it’s not possible to log without building OC\Memcache\Factory I added a...

> So the fix is in Server.php and the other changes in index.php are only to modernize how we get the logger right? Exactly!

@ChristophWurst please can you approve this for merging?

Something else that has come up while working on this in relation to maintaining "Allow editing" and "Default permissions" - It turns out when no permissions are set on the...