tools icon indicating copy to clipboard operation
tools copied to clipboard

TEMPLATE - add trainling slash for pipelines_testdata_base_path

Open maxulysse opened this issue 5 months ago • 2 comments

from @vagkaratzas

Would it be too much pain to put a slash at the end of pipelines_testdata_base_path in tests/nextflow.config, in the next template update? Currently it's different to the modules_testdata_base_path above. Would be nice to have uniformity in tests throughout conf/ tests/ and modules-subworkflows tests. I've left a relevant though-comment on this PR: https://github.com/nf-core/methylseq/pull/558#discussion_r2253615940

PR checklist

  • [ ] This comment contains a description of changes (with reason)
  • [ ] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

maxulysse avatar Aug 05 '25 09:08 maxulysse

good question, maybe we should indeed

maxulysse avatar Aug 12 '25 09:08 maxulysse

hmm, not sure it's worth the template merge pain to be honest. Maybe we can bookmark the change and do it in the future, together with other changes that we may need to make then?

ewels avatar Oct 09 '25 19:10 ewels