tools icon indicating copy to clipboard operation
tools copied to clipboard

Update template according to new specification

Open famosab opened this issue 1 year ago • 6 comments

PR checklist

  • [x] This comment contains a description of changes (with reason)
  • [x] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

I updated the modules template according to this PR. This way of handing the test data was enforced during the march 2024 hackathon and I thought it should be reflected in the template 😄

famosab avatar May 15 '24 12:05 famosab

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @famosab,

It looks like this pull-request is has been made against the famosab/tools master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the famosab/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar May 15 '24 12:05 github-actions[bot]

Can you add a CHANGELOG entry in the TEMPLATE section

maxulysse avatar May 15 '24 12:05 maxulysse

How excatly do I need to add this? as a new patch?

famosab avatar May 15 '24 12:05 famosab

How excatly do I need to add this? as a new patch?

No need to worry about that, you were based on master, the tag was on dev

maxulysse avatar May 15 '24 12:05 maxulysse

There is still one check failing ... :(

famosab avatar May 15 '24 12:05 famosab

@mirpedrol any idea?

maxulysse avatar May 15 '24 13:05 maxulysse

@mirpedrol Still one test: test_components with 3.8 which is failing :(

famosab avatar May 22 '24 10:05 famosab

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.19%. Comparing base (e6b089b) to head (5fc3069).

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 10:05 codecov[bot]

All green now ✅ thanks!

mirpedrol avatar May 22 '24 11:05 mirpedrol