tools
tools copied to clipboard
Add docker_m1 profile
- Add
docker_m1
profile to pipeline as suggested by @snafees to be able to run pipelines with the docker profile on the Apple M1 chips
PR checklist
- [ ] This comment contains a description of changes (with reason)
- [ ]
CHANGELOG.md
is updated - [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] Documentation in
docs
is updated
Codecov Report
Merging #1942 (addf973) into dev (bacb003) will decrease coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #1942 +/- ##
==========================================
- Coverage 67.41% 67.36% -0.06%
==========================================
Files 42 42
Lines 5463 5463
==========================================
- Hits 3683 3680 -3
- Misses 1780 1783 +3
Impacted Files | Coverage Δ | |
---|---|---|
nf_core/modules/test_yml_builder.py | 48.18% <0.00%> (-1.37%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@nf-core-bot fix linting
I think this needs to come with some kind of documented warning, either at runtime, in the docs, or (preferably imo) both. Whilst the platform option does allow you to get a lot of the functionality and compatibility it can also lead to incredibly slow processes where the emulation doesn't cut it.
It's also possible that you lose a lot of performance running under emulation when native arm
containers might actually be available.
EDIT: In fact I don't think the platform variable is necessary to pull amd64
containers when they are the only ones which exist. So setting it only ensures you will never get a (potentially more performant) apple-silicon native container
a bit late to the party, but why not using the current docker profile and adding an arm profile with just the docker option so we can do
-profile docker,arm
?
why not using the current docker profile and adding an arm profile with just the docker option so we can do
-profile docker,arm
?
Good idea :) I made the PR here https://github.com/nf-core/tools/pull/2034