tools icon indicating copy to clipboard operation
tools copied to clipboard

add nf-core subworkflows list and info commands

Open bjlang opened this issue 3 years ago • 1 comments

PR checklist

  • [ ] This comment contains a description of changes (with reason)
  • [ ] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

bjlang avatar Oct 11 '22 10:10 bjlang

Codecov Report

Merging #1919 (974c6c1) into dev (c005f03) will decrease coverage by 1.49%. The diff coverage is 23.07%.

:exclamation: Current head 974c6c1 differs from pull request most recent head dc60869. Consider uploading reports for the commit dc60869 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1919      +/-   ##
==========================================
- Coverage   65.31%   63.82%   -1.50%     
==========================================
  Files          42       43       +1     
  Lines        5322     5517     +195     
==========================================
+ Hits         3476     3521      +45     
- Misses       1846     1996     +150     
Impacted Files Coverage Δ
nf_core/modules/modules_repo.py 78.87% <12.50%> (-2.60%) :arrow_down:
nf_core/subworkflows/info.py 16.77% <16.77%> (ø)
nf_core/__main__.py 58.86% <50.00%> (-0.61%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 11 '22 12:10 codecov[bot]

@nf-core-bot fix linting

mirpedrol avatar Nov 15 '22 14:11 mirpedrol

Hi @bjlang are the tests on this PR finished? Or is it still WIP? We are thinking on merging it for the next release (which will hopefully happen during next week)

mirpedrol avatar Nov 16 '22 09:11 mirpedrol

@mirpedrol tests were finished. But I assume that more of this will become invalid/irrelevant with the move to components

bjlang avatar Nov 16 '22 16:11 bjlang

tests were finished.

Finished as you wrote them? Because I can't see them in the PR.

But I assume that more of this will become invalid/irrelevant with the move to components

Partially, but this is a very good starting point for the move. 🙂

mashehu avatar Nov 16 '22 18:11 mashehu