tools
tools copied to clipboard
Extended the hook_url functionality to Slack
Hello,
Got very interested in what @matthdsm did in #1798 . This is a small extension to support Slack as well, since Slack doesn't understand adaptive cards.
Here is how the notifications look like:
![Screenshot 2022-09-16 at 11 16 27](https://user-images.githubusercontent.com/623458/190623291-02e9be70-edc5-4ef5-8e0f-7d8c156fc0d6.png)
![Screenshot 2022-09-16 at 11 38 18](https://user-images.githubusercontent.com/623458/190623264-bc35dc03-7c7a-4cf9-aece-c4e60944800d.png)
The JSON has a very long and tricky line where I try to improve the look-and-feel of the pipeline configuration:
- paths are printed as code
- dates are formatted according to the locale settings
- the hook_url itself is hidden
Note: I am using the legacy "attachments" method of the Slack API, rather than the now-recommended Block Kit method, because I couldn't find how to make the latter put some colour. I think one has to immediately know whether it failed or not, and the colour is faster to recognise than the text itself.
PR checklist
- [x] This comment contains a description of changes (with reason)
- [x]
CHANGELOG.md
is updated - [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] Documentation in
docs
is updated
Codecov Report
Merging #1829 (33a09af) into dev (7010335) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## dev #1829 +/- ##
=======================================
Coverage 63.74% 63.74%
=======================================
Files 41 41
Lines 4913 4913
=======================================
Hits 3132 3132
Misses 1781 1781
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Love it, just left one small comment
IM_notification
can do. I feel uninspired today and can't find a better name
Is this considered to be superseded by https://github.com/Midnighter/nf-slack ?
Thank you !
Please add documentation about this https://github.com/nf-core/nf-co.re/issues/1455