tools icon indicating copy to clipboard operation
tools copied to clipboard

Custom name

Open mirpedrol opened this issue 3 years ago • 4 comments

Check that the workflow name provided with a template doesn't contain dashes. Closes #1806 Ask for Name instead of Workflow name when creating a pipeline with prompts. Closes #1805

PR checklist

  • [x] This comment contains a description of changes (with reason)
  • [x] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [x] Documentation in docs is updated

mirpedrol avatar Sep 08 '22 13:09 mirpedrol

Codecov Report

Merging #1822 (0004b9b) into dev (b6be4ff) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1822   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files          37       37           
  Lines        4677     4677           
=======================================
  Hits         2858     2858           
  Misses       1819     1819           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 08 '22 14:09 codecov[bot]

Reasoning is here: https://github.com/nf-core/tools/issues/1805

I agree that Name is too vague though. I'd prefer to go the other way with --workflow-name I think (or ignore the issue and do nothing).

ewels avatar Sep 20 '22 12:09 ewels

Need to update the readme example too:

https://github.com/nf-core/tools/blob/bc56cdd35077e408a0a7c90ec07fcdff7c2d1f3b/README.md?plain=1#L404

ewels avatar Sep 20 '22 12:09 ewels

Need to update the readme example too:

https://github.com/nf-core/tools/blob/bc56cdd35077e408a0a7c90ec07fcdff7c2d1f3b/README.md?plain=1#L404

Done in #1821

mashehu avatar Sep 20 '22 12:09 mashehu