"since" has no effect

Open fabianegli opened this issue 3 years ago • 1 comments

Can the argument and its documentation be removed? Or does the code need to be adapted to fulfill the docs?

https://github.com/nf-core/tools/blob/bc56cdd35077e408a0a7c90ec07fcdff7c2d1f3b/nf_core/modules/modules_repo.py#L348-L368

Sep 07 '22 14:09 fabianegli

@ErikDanielsson Do you have preferences how to solve this issue?

Sep 23 '22 14:09 fabianegli

I went ahead and cleaned the function signature and docstring according to the function body. I still think this is a question deserving an answer.

Oct 21 '22 07:10 fabianegli

I think it is fine to remove it. If we see a need for this functionality we can add it. I didn't find any more mention of this functionality except for modules_repo.py. Thanks for finding this!

Oct 21 '22 11:10 mashehu