tools icon indicating copy to clipboard operation
tools copied to clipboard

Fix broken link in `nf-core modules info`

Open mirpedrol opened this issue 3 years ago • 2 comments

Close #1736

Don't add the prefix https://github.com to the link created by nf-core modules info. Make the link clickable if self.remote_location starts by 'http'

The command was also failing when there wasn't any module installed from a remote repository. I added the attribute self.local to ensure that we only try to obtain information from a local module if it is locally installed.

PR checklist

  • [x] This comment contains a description of changes (with reason)
  • [x] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

mirpedrol avatar Aug 08 '22 07:08 mirpedrol

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @mirpedrol,

It looks like this pull-request is has been made against the mirpedrol/tools master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the mirpedrol/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar Aug 08 '22 07:08 github-actions[bot]

Codecov Report

Merging #1745 (c3b32d5) into dev (ccad6e6) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1745      +/-   ##
==========================================
- Coverage   68.45%   68.44%   -0.01%     
==========================================
  Files          59       59              
  Lines        7136     7137       +1     
==========================================
  Hits         4885     4885              
- Misses       2251     2252       +1     
Impacted Files Coverage Δ
nf_core/modules/info.py 17.03% <0.00%> (-0.13%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 08 '22 07:08 codecov[bot]

Haven't tested it, but reading the code looks good 🚀

ewels avatar Aug 18 '22 08:08 ewels