tools icon indicating copy to clipboard operation
tools copied to clipboard

Cleanup licenses

Open fabianegli opened this issue 3 years ago • 2 comments

Closes #1712

PR checklist

  • [ ] This comment contains a description of changes (with reason)
  • [ ] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

fabianegli avatar Jul 28 '22 14:07 fabianegli

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @fabianegli,

It looks like this pull-request is has been made against the fabianegli/tools master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the fabianegli/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar Jul 28 '22 14:07 github-actions[bot]

Codecov Report

Merging #1713 (71025cc) into dev (20ad2aa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1713   +/-   ##
=======================================
  Coverage   69.22%   69.22%           
=======================================
  Files          59       59           
  Lines        7142     7142           
=======================================
  Hits         4944     4944           
  Misses       2198     2198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 28 '22 14:07 codecov[bot]

Hello, is this PR still a WIP? Or should we close it and open a new one changing the way the command nf-core licenses works? As you discussed in https://github.com/nf-core/tools/issues/1712

mirpedrol avatar Apr 06 '23 12:04 mirpedrol

Gulp this is an old one. The question in the linked issue seems to remain unanswered. Also, it is commented out code and as such should in my opinion not be merged. Only if there is a resolution about how to treat/retrieve the license information and the code becomes useful should it enter the repo. It was a bit of an exploration and experimentation and I currently don't have the capacity to work on this. In the current state this PR merely serves as a reminder that there is code to either remove or reactivate.

fabianegli avatar Apr 06 '23 14:04 fabianegli