tools icon indicating copy to clipboard operation
tools copied to clipboard

Split README to separate md documents into split_mds folder

Open karegapauline opened this issue 3 years ago β€’ 7 comments

PR checklist

  • [ ] This comment contains a description of changes (with reason)
  • [ ] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

karegapauline avatar Mar 16 '22 11:03 karegapauline

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @karegapauline,

It looks like this pull-request is has been made against the karegapauline/tools master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the karegapauline/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar Mar 16 '22 11:03 github-actions[bot]

Codecov Report

Merging #1458 (c9e8d13) into dev (3abb7ef) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1458   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files          52       52           
  Lines        6055     6055           
=======================================
  Hits         3928     3928           
  Misses       2127     2127           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 3abb7ef...c9e8d13. Read the comment docs.

codecov[bot] avatar Mar 16 '22 11:03 codecov[bot]

Great! Small thing from a first glance - please use all lower-caps for the filenames, as these will be used for the URLs.

ewels avatar Mar 16 '22 11:03 ewels

I like the idea with the subdirectories for schema, modules, etc., but I would propose to have then all files inside a directory called markdown, so the don't get mixed up with the two other directories.

mashehu avatar Mar 17 '22 09:03 mashehu

Ah I forgot we already have api there, ok yeah - docs/markdown is good then πŸ‘πŸ»

ewels avatar Mar 17 '22 10:03 ewels

@karegapauline I just fixed the merge conflicts and then ran the new linting - please make sure you pull these changes before making any more edits..

ewels avatar Mar 18 '22 11:03 ewels

Getting better, thanks for these updates!

One more thing: For the subcommands that have been broken into pages, could we have directories named after the subcommands?

So docs/markdown/modules/creating_new_modules.md for example.

Just to make it a little easier to navigate the docs.

ewels avatar Mar 18 '22 11:03 ewels

Needs significant updates now and will probably be approached slightly differently with the website rewrite. Closing for now, can reopen closer to the time if the final implementation looks like it will use the same syntax πŸ‘πŸ»

ewels avatar Aug 22 '22 11:08 ewels