Openms idxml

[rolivella]

This is for uploading data to test OpenMS idXML module

[ggabernet]

Hi @rolivella , thanks for adding the test data! Could you have a look at the README.md and add the data in the corresponding subfolder (e.g. proteomics)? Also a short description of where the data comes from

[rolivella]

@ggabernet I just added the documentation and pull request

[rolivella]

@JoseEspinosa I already made your requested changes. Could you merge please?

[ggabernet]

Hi @rolivella, checking this PR again, we try to keep an orderly folder structure, so that it will be easy to find the test data by everyone. It seems like this is the first proteomics dataset! 🎉 I would be therefore great to add it to a new directory called: "proteomics", and a subdirectory with the name of the species that the data comes from. See the other directory structure for e.g. genomics for an inspiration.

[rolivella]

Hi @ggabernet I think that there's already a folder called "proteomics" here:

https://github.com/nf-core/test-datasets/tree/modules/data/proteomics

But is not following the structure you mentioned with the species and so on. What should I do?

[ggabernet]

In that case you can add a subdirectory under proteomics with the species name, and add your test data underneath. So that other proteomics datasets can follow the recommended structure 😄

[rolivella]

@ggabernet ok! I'll do it and let you know!

[ggabernet]

Great, looks good to me then! @JoseEspinosa is there any other changes that you wanted there?