smrnaseq
smrnaseq copied to clipboard
WIP PR for Release 2.4.0
PR checklist
- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
- [ ] If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
- [ ] Make sure your code lints (
nf-core lint). - [ ] Ensure the test suite passes (
nf-test test main.nf.test -profile test,docker). - [ ] Check for unexpected warnings in debug mode (
nextflow run . -profile debug,test,docker --outdir <OUTDIR>). - [ ] Usage Documentation in
docs/usage.mdis updated. - [ ] Output Documentation in
docs/output.mdis updated. - [ ]
CHANGELOG.mdis updated. - [ ]
README.mdis updated (including new tool citations and authors/contributors).
nf-core pipelines lint overall result: Passed :white_check_mark: :warning:
Posted for pipeline commit 3876a7a
+| ✅ 246 tests passed |+
#| ❔ 1 tests were ignored |#
!| ❗ 1 tests had warnings |!
:heavy_exclamation_mark: Test warnings:
-
schema_description - Ungrouped param in schema:
igenomes_base
:grey_question: Tests ignored:
- nextflow_config - Config default ignored: params.fastp_known_mirna_adapters
:white_check_mark: Tests passed:
-
files_exist - File found:
.gitattributes -
files_exist - File found:
.gitignore -
files_exist - File found:
.nf-core.yml -
files_exist - File found:
.editorconfig -
files_exist - File found:
.prettierignore -
files_exist - File found:
.prettierrc.yml -
files_exist - File found:
CHANGELOG.md -
files_exist - File found:
CITATIONS.md -
files_exist - File found:
CODE_OF_CONDUCT.md -
files_exist - File found:
LICENSEorLICENSE.mdorLICENCEorLICENCE.md -
files_exist - File found:
nextflow_schema.json -
files_exist - File found:
nextflow.config -
files_exist - File found:
README.md -
files_exist - File found:
.github/.dockstore.yml -
files_exist - File found:
.github/CONTRIBUTING.md -
files_exist - File found:
.github/ISSUE_TEMPLATE/bug_report.yml -
files_exist - File found:
.github/ISSUE_TEMPLATE/config.yml -
files_exist - File found:
.github/ISSUE_TEMPLATE/feature_request.yml -
files_exist - File found:
.github/PULL_REQUEST_TEMPLATE.md -
files_exist - File found:
.github/workflows/branch.yml -
files_exist - File found:
.github/workflows/ci.yml -
files_exist - File found:
.github/workflows/linting_comment.yml -
files_exist - File found:
.github/workflows/linting.yml -
files_exist - File found:
assets/email_template.html -
files_exist - File found:
assets/email_template.txt -
files_exist - File found:
assets/sendmail_template.txt -
files_exist - File found:
assets/nf-core-smrnaseq_logo_light.png -
files_exist - File found:
conf/modules.config -
files_exist - File found:
conf/test.config -
files_exist - File found:
conf/test_full.config -
files_exist - File found:
docs/images/nf-core-smrnaseq_logo_light.png -
files_exist - File found:
docs/images/nf-core-smrnaseq_logo_dark.png -
files_exist - File found:
docs/output.md -
files_exist - File found:
docs/README.md -
files_exist - File found:
docs/README.md -
files_exist - File found:
docs/usage.md -
files_exist - File found:
main.nf -
files_exist - File found:
assets/multiqc_config.yml -
files_exist - File found:
conf/base.config -
files_exist - File found:
conf/igenomes.config -
files_exist - File found:
conf/igenomes_ignored.config -
files_exist - File found:
.github/workflows/awstest.yml -
files_exist - File found:
.github/workflows/awsfulltest.yml -
files_exist - File found:
modules.json -
files_exist - File not found check:
.github/ISSUE_TEMPLATE/bug_report.md -
files_exist - File not found check:
.github/ISSUE_TEMPLATE/feature_request.md -
files_exist - File not found check:
.github/workflows/push_dockerhub.yml -
files_exist - File not found check:
.markdownlint.yml -
files_exist - File not found check:
.nf-core.yaml -
files_exist - File not found check:
.yamllint.yml -
files_exist - File not found check:
bin/markdown_to_html.r -
files_exist - File not found check:
conf/aws.config -
files_exist - File not found check:
docs/images/nf-core-smrnaseq_logo.png -
files_exist - File not found check:
lib/Checks.groovy -
files_exist - File not found check:
lib/Completion.groovy -
files_exist - File not found check:
lib/NfcoreTemplate.groovy -
files_exist - File not found check:
lib/Utils.groovy -
files_exist - File not found check:
lib/Workflow.groovy -
files_exist - File not found check:
lib/WorkflowMain.groovy -
files_exist - File not found check:
lib/WorkflowSmrnaseq.groovy -
files_exist - File not found check:
parameters.settings.json -
files_exist - File not found check:
pipeline_template.yml -
files_exist - File not found check:
Singularity -
files_exist - File not found check:
lib/nfcore_external_java_deps.jar -
files_exist - File not found check:
.travis.yml - nextflow_config - Found nf-schema plugin
-
nextflow_config - Config variable found:
manifest.name -
nextflow_config - Config variable found:
manifest.nextflowVersion -
nextflow_config - Config variable found:
manifest.description -
nextflow_config - Config variable found:
manifest.version -
nextflow_config - Config variable found:
manifest.homePage -
nextflow_config - Config variable found:
timeline.enabled -
nextflow_config - Config variable found:
trace.enabled -
nextflow_config - Config variable found:
report.enabled -
nextflow_config - Config variable found:
dag.enabled -
nextflow_config - Config variable found:
process.cpus -
nextflow_config - Config variable found:
process.memory -
nextflow_config - Config variable found:
process.time -
nextflow_config - Config variable found:
params.outdir -
nextflow_config - Config variable found:
params.input -
nextflow_config - Config variable found:
validation.help.enabled -
nextflow_config - Config variable found:
manifest.mainScript -
nextflow_config - Config variable found:
timeline.file -
nextflow_config - Config variable found:
trace.file -
nextflow_config - Config variable found:
report.file -
nextflow_config - Config variable found:
dag.file -
nextflow_config - Config variable found:
validation.help.beforeText -
nextflow_config - Config variable found:
validation.help.afterText -
nextflow_config - Config variable found:
validation.help.command -
nextflow_config - Config variable found:
validation.summary.beforeText -
nextflow_config - Config variable found:
validation.summary.afterText -
nextflow_config - Config variable (correctly) not found:
params.nf_required_version -
nextflow_config - Config variable (correctly) not found:
params.container -
nextflow_config - Config variable (correctly) not found:
params.singleEnd -
nextflow_config - Config variable (correctly) not found:
params.igenomesIgnore -
nextflow_config - Config variable (correctly) not found:
params.name -
nextflow_config - Config variable (correctly) not found:
params.enable_conda -
nextflow_config - Config variable (correctly) not found:
params.max_cpus -
nextflow_config - Config variable (correctly) not found:
params.max_memory -
nextflow_config - Config variable (correctly) not found:
params.max_time -
nextflow_config - Config variable (correctly) not found:
params.validationFailUnrecognisedParams -
nextflow_config - Config variable (correctly) not found:
params.validationLenientMode -
nextflow_config - Config variable (correctly) not found:
params.validationSchemaIgnoreParams -
nextflow_config - Config variable (correctly) not found:
params.validationShowHiddenParams -
nextflow_config - Config
timeline.enabledhad correct value:true -
nextflow_config - Config
report.enabledhad correct value:true -
nextflow_config - Config
trace.enabledhad correct value:true -
nextflow_config - Config
dag.enabledhad correct value:true -
nextflow_config - Config
manifest.namebegan withnf-core/ -
nextflow_config - Config variable
manifest.homePagebegan with https://github.com/nf-core/ -
nextflow_config - Config
dag.fileended with.html -
nextflow_config - Config variable
manifest.nextflowVersionstarted with >= or !>= -
nextflow_config - Config
manifest.versiondoes not containdevfor release:2.4.0 -
nextflow_config - Config
params.custom_config_versionis set tomaster -
nextflow_config - Config
params.custom_config_baseis set tohttps://raw.githubusercontent.com/nf-core/configs/master - nextflow_config - Lines for loading custom profiles found
-
nextflow_config - nextflow.config contains configuration profile
test - nextflow_config - Config default value correct: params.igenomes_base= s3://ngi-igenomes/igenomes/
- nextflow_config - Config default value correct: params.umitools_extract_method= string
- nextflow_config - Config default value correct: params.umitools_method= dir
- nextflow_config - Config default value correct: params.skip_umi_extract_before_dedup= true
- nextflow_config - Config default value correct: params.mature= https://github.com/nf-core/test-datasets/raw/smrnaseq/miRBase/mature.fa
- nextflow_config - Config default value correct: params.hairpin= https://github.com/nf-core/test-datasets/raw/smrnaseq/miRBase/hairpin.fa
- nextflow_config - Config default value correct: params.three_prime_adapter= AGATCGGAAGAGCACACGTCTGAACTCCAGTCA
- nextflow_config - Config default value correct: params.trim_fastq= true
- nextflow_config - Config default value correct: params.fastp_min_length= 17
- nextflow_config - Config default value correct: params.fastp_max_length= 100
- nextflow_config - Config default value correct: params.min_trimmed_reads= 10
- nextflow_config - Config default value correct: params.save_merged= false
- nextflow_config - Config default value correct: params.phred_offset= 33
- nextflow_config - Config default value correct: params.custom_config_version= master
- nextflow_config - Config default value correct: params.custom_config_base= https://raw.githubusercontent.com/nf-core/configs/master
- nextflow_config - Config default value correct: params.publish_dir_mode= copy
- nextflow_config - Config default value correct: params.max_multiqc_email_size= 25.MB
- nextflow_config - Config default value correct: params.validate_params= true
- nextflow_config - Config default value correct: params.pipelines_testdata_base_path= https://raw.githubusercontent.com/nf-core/test-datasets/
-
files_unchanged -
.gitattributesmatches the template -
files_unchanged -
.prettierrc.ymlmatches the template -
files_unchanged -
CODE_OF_CONDUCT.mdmatches the template -
files_unchanged -
LICENSEmatches the template -
files_unchanged -
.github/.dockstore.ymlmatches the template -
files_unchanged -
.github/CONTRIBUTING.mdmatches the template -
files_unchanged -
.github/ISSUE_TEMPLATE/bug_report.ymlmatches the template -
files_unchanged -
.github/ISSUE_TEMPLATE/config.ymlmatches the template -
files_unchanged -
.github/ISSUE_TEMPLATE/feature_request.ymlmatches the template -
files_unchanged -
.github/PULL_REQUEST_TEMPLATE.mdmatches the template -
files_unchanged -
.github/workflows/branch.ymlmatches the template -
files_unchanged -
.github/workflows/linting_comment.ymlmatches the template -
files_unchanged -
.github/workflows/linting.ymlmatches the template -
files_unchanged -
assets/email_template.htmlmatches the template -
files_unchanged -
assets/email_template.txtmatches the template -
files_unchanged -
assets/sendmail_template.txtmatches the template -
files_unchanged -
assets/nf-core-smrnaseq_logo_light.pngmatches the template -
files_unchanged -
docs/images/nf-core-smrnaseq_logo_light.pngmatches the template -
files_unchanged -
docs/images/nf-core-smrnaseq_logo_dark.pngmatches the template -
files_unchanged -
docs/README.mdmatches the template -
files_unchanged -
.gitignorematches the template -
files_unchanged -
.prettierignorematches the template - actions_ci - '.github/workflows/ci.yml' is triggered on expected events
- actions_ci - '.github/workflows/ci.yml' checks minimum NF version
- actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
-
actions_awsfulltest -
.github/workflows/awsfulltest.ymlis triggered correctly -
actions_awsfulltest -
.github/workflows/awsfulltest.ymldoes not use-profile test -
readme - README Nextflow minimum version badge matched config. Badge:
24.04.2, Config:24.04.2 - readme - README Zenodo placeholder was replaced with DOI.
- pipeline_todos - No TODO strings found
- plugin_includes - No wrong validation plugin imports have been found
- pipeline_name_conventions - Name adheres to nf-core convention
- template_strings - Did not find any Jinja template strings (0 files)
- schema_lint - Schema lint passed
- schema_lint - Schema title + description lint passed
- schema_lint - Input mimetype lint passed: 'text/csv'
- schema_params - Schema matched params returned from nextflow config
-
system_exit - No
System.exitcalls found - actions_schema_validation - Workflow validation passed: linting.yml
- actions_schema_validation - Workflow validation passed: branch.yml
- actions_schema_validation - Workflow validation passed: fix-linting.yml
- actions_schema_validation - Workflow validation passed: release-announcements.yml
- actions_schema_validation - Workflow validation passed: awsfulltest.yml
- actions_schema_validation - Workflow validation passed: template_version_comment.yml
- actions_schema_validation - Workflow validation passed: download_pipeline.yml
- actions_schema_validation - Workflow validation passed: ci.yml
- actions_schema_validation - Workflow validation passed: clean-up.yml
- actions_schema_validation - Workflow validation passed: awstest.yml
- actions_schema_validation - Workflow validation passed: linting_comment.yml
- merge_markers - No merge markers found in pipeline files
-
modules_json - Only installed modules found in
modules.json -
multiqc_config -
assets/multiqc_config.ymlfound and not ignored. -
multiqc_config -
assets/multiqc_config.ymlcontainsreport_section_order -
multiqc_config -
assets/multiqc_config.ymlcontainsexport_plots -
multiqc_config -
assets/multiqc_config.ymlcontainsreport_comment -
multiqc_config -
assets/multiqc_config.ymlfollows the ordering scheme of the minimally required plugins. -
multiqc_config -
assets/multiqc_config.ymlcontains a matching 'report_comment'. -
multiqc_config -
assets/multiqc_config.ymlcontains 'export_plots: true'. - modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
-
base_config -
conf/base.configfound and not ignored. -
modules_config -
conf/modules.configfound and not ignored. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
CAT_FASTQfound inconf/modules.configand Nextflow scripts. -
modules_config -
FASTP_LENGTH_FILTERfound inconf/modules.configand Nextflow scripts. -
modules_config -
INDEX_GENOMEfound inconf/modules.configand Nextflow scripts. -
modules_config -
CLEAN_FASTAfound inconf/modules.configand Nextflow scripts. -
modules_config -
UMITOOLS_EXTRACTfound inconf/modules.configand Nextflow scripts. -
modules_config -
MIRTRACE_QCfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
EDGER_QCfound inconf/modules.configand Nextflow scripts. -
modules_config -
SEQCLUSTER_COLLAPSEfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
SAMTOOLS_INDEXfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
NFCORE_SMRNASEQfound inconf/modules.configand Nextflow scripts. -
modules_config -
MIRDEEP2_MAPPERfound inconf/modules.configand Nextflow scripts. -
modules_config -
SEQKIT_REPLACEfound inconf/modules.configand Nextflow scripts. -
modules_config -
SEQKIT_FQ2FAfound inconf/modules.configand Nextflow scripts. -
modules_config -
MIRDEEP2_MIRDEEP2found inconf/modules.configand Nextflow scripts. -
modules_config -
MULTIQCfound inconf/modules.configand Nextflow scripts. -
nfcore_yml - Repository type in
.nf-core.ymlis valid:pipeline -
nfcore_yml - nf-core version in
.nf-core.ymlis set to the latest version:3.0.2 - version_consistency - Version tags are numeric and consistent between container, release tag and config.
- included_configs - Pipeline config includes custom configs.
Run details
- nf-core/tools version 3.0.2
- Run at
2024-10-14 09:57:15
Most of the points added for another release / extra issues created - if @atrigila @nschcolnicov have some minutes maybe we can try tackling the points already here within this one :)