sarek icon indicating copy to clipboard operation
sarek copied to clipboard

Output from ascat not stable

Open asp8200 opened this issue 2 years ago • 4 comments

Description of the bug

When running the following test, which is also also part of the CI-test tests/test_tools_manually.yml,

nextflow run main.nf -profile test,tools_somatic_ascat

@SusiJo found that the content (not just timestamps or something like that, but proper values!) of the output-files

results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourBAF.txt
results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourLogR.txt

change on reruns:

image

Command used and terminal output

nextflow run main.nf -profile test,tools_somatic_ascat


"unstable" output-files
results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourBAF.txt
results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourLogR.txt

Relevant files

sample4_vs_sample3.tumour_tumourBAF.txt from consecutive runs of the test:

ascat2.zip ascat1.zip

System information

No response

asp8200 avatar Aug 11 '22 12:08 asp8200

what did you use to run it? Docker?

FriederikeHanssen avatar Aug 11 '22 12:08 FriederikeHanssen

what did you use to run it? Docker?

@SusiJo told me she used Docker.

asp8200 avatar Aug 11 '22 12:08 asp8200

Looking at the manual here: https://raw.githubusercontent.com/VanLoo-lab/ascat/master/man/ASCAT-manual.pdf looks like one can set seeds for a few functions. Haven't cross-checked them with the ones that are used, but seems like a good place to start.

FriederikeHanssen avatar Aug 11 '22 12:08 FriederikeHanssen

So they fixed the issue on the master branch but we probably need to wait for the 3.1 release to make a new mulled container.

SusiJo avatar Oct 11 '22 13:10 SusiJo

Hey! Let's keep this open until it is actually merged into the pipeline and added to the changelog or we will forget :)

FriederikeHanssen avatar Apr 05 '23 06:04 FriederikeHanssen