sarek icon indicating copy to clipboard operation
sarek copied to clipboard

Published 20 hours ago • verified publisher icon nf-core

Update TEMPLATE

Open maxulysse opened this issue 1 year ago • 2 comments

PR checklist

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
    • [ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • [ ] Make sure your code lints (nf-core lint).
  • [ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [ ] Usage Documentation in docs/usage.md is updated.
  • [ ] Output Documentation in docs/output.md is updated.
  • [ ] CHANGELOG.md is updated.
  • [ ] README.md is updated (including new tool citations and authors/contributors).

maxulysse avatar Jul 26 '22 09:07 maxulysse

nf-core lint overall result: Failed :x:

Posted for pipeline commit 289aa53

+| ✅ 140 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!
-| ❌   7 tests failed       |-

:x: Test failures:

  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - assets/email_template.txt does not match the template
  • actions_ci - '.github/workflows/ci.yml' does not check minimum NF version
  • modules_json - Entry for base_path found in modules.json but module is not installed in pipeline.
  • modules_json - Entry for git_url found in modules.json but module is not installed in pipeline.
  • modules_json - Entry for modules found in modules.json but module is not installed in pipeline.

:heavy_exclamation_mark: Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

:grey_question: Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

:white_check_mark: Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-26 11:25:36

github-actions[bot] avatar Jul 26 '22 09:07 github-actions[bot]

DO NOT MERGE yet as it'll break tools if you don't have the current dev (modules updates)

maxulysse avatar Jul 26 '22 09:07 maxulysse