rnaseq icon indicating copy to clipboard operation
rnaseq copied to clipboard

3.16.x does not allow numeric sample ids

Open idot opened this issue 1 year ago • 3 comments

Description of the bug

Hello, a samples.csv that was working in 3.15.1 is not accepted anymore. The file has numeric sample ids. Prepending them with x makes it work again. However numeric sample ids are very common and there is no reason that they should not be valid.

* --input (/users/ido.tamir/work/analysis/rnaseq/ribozero_align_20241017.csv): Validation of file failed:
        -> Entry 1: Error for field 'sample' (298098): Sample name must be provided and cannot contain spaces
        -> Entry 2: Error for field 'sample' (298504): Sample name must be provided and cannot contain spaces
        -> Entry 3: Error for field 'sample' (317960): Sample name must be provided and cannot contain spaces
        -> Entry 4: Error for field 'sample' (319093): Sample name must be provided and cannot contain spaces
        -> Entry 5: Error for field 'sample' (297292): Sample name must be provided and cannot contain spaces
        -> Entry 6: Error for field 'sample' (320543): Sample name must be provided and cannot contain spaces

Command used and terminal output

nextflow run -r 3.16.1 nf-core/rnaseq --input test.csv --genome hg38 --outdir .

Relevant files

test.csv

System information

  • nextflow 24.04.4
  • HPC
  • slurm
  • Singularity
  • Linux
  • nf-core/rnaseq 3.16.0,3.16.1

idot avatar Oct 17 '24 12:10 idot

There must be some wierd invisible characters in the file. Another file with only numeric ids did work.

idot avatar Oct 17 '24 14:10 idot

is indeed an issue. added pull request

idot avatar Oct 18 '24 11:10 idot

The error persists in 3.18.0:

      -> Entry 1: Error for field 'sample' (343851): Value is [integer] but should be [string] (Sample name must be provided and cannot contain spaces)
        -> Entry 2: Error for field 'sample' (343852): Value is [integer] but should be [string] (Sample name must be provided and cannot contain spaces)
        -> Entry 3: Error for field 'sample' (343853): Value is [integer] but should be [string] (Sample name must be provided and cannot contain spaces)
        -> Entry 4: Error for field 'sample' (343854): Value is [integer] but should be [string] (Sample name must be provided and cannot contain spaces)
        -> Entry 5: Error for field 'sample' (343855): Value is [integer] but should be [string] (Sample name must be provided and cannot contain spaces)

idot avatar Mar 03 '25 13:03 idot