proteomicslfq icon indicating copy to clipboard operation
proteomicslfq copied to clipboard

Version parsing regex can't parse some valid version

Open fabianegli opened this issue 4 years ago • 2 comments

https://github.com/nf-core/proteomicslfq/blob/43c77e50c955d7e62899e7d31e0d6f6a87ac2316/bin/scrape_software_versions.py#L6

The above regex r"([0-9][.][0-9][.][0-9])" doesn't match the historic openMS version 1.11.0. I think the regex should be either expanded to allow multi digit main, minor and bug release versions or maybe even be expanded to match all Semantic Versioning 2.0.0, if that is indeed what openMS (and the other tools) adheres to. The SemVer website contains regexes with and without named groups: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

fabianegli avatar Oct 06 '21 11:10 fabianegli

... and the regexes got ditched for this job. See the current scrape_software_versions.py and this PR diff.

fabianegli avatar Oct 18 '21 22:10 fabianegli

I think version parsing probably just moved to each module.

jpfeuffer avatar Oct 19 '21 07:10 jpfeuffer