modules icon indicating copy to clipboard operation
modules copied to clipboard

split the fastq and fastq_idx outputs from cellranger mkfastq module

Open gordond88 opened this issue 6 months ago • 1 comments

Issue: cellranger mkfastq outputs both fastq and fastq_idx files together which causes issues with some other processes (e.g. falco couldn't process index fastqs in the demultiplex pipeline).

Solution: split the fastq and fastq_idx outputs from cellranger mkfastq module.

PR checklist

Closes https://github.com/nf-core/demultiplex/pull/333

  • [x] This comment contains a description of changes (with reason).
  • [ ] Follow the input/output options guidelines.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda

gordond88 avatar Jun 19 '25 08:06 gordond88

Hi @gordond88 , you need to update the snapshots for the tests by running: nf-core modules test cellranger/mkfastq -u You'll also need to update the meta.yml file to reflect the fact you've added a new channel.

SPPearce avatar Jun 21 '25 13:06 SPPearce

Closing in favour of #9204

SPPearce avatar Oct 17 '25 09:10 SPPearce