modules icon indicating copy to clipboard operation
modules copied to clipboard

Added module lmm and copied kinshipmatrix module

Open KevinMLanderos opened this issue 7 months ago • 3 comments

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

KevinMLanderos avatar May 14 '25 20:05 KevinMLanderos

WIP

When running nf-core modules test gemma/lmm, keep getting error highlighting midas module dependency, which should not be needed

KevinMLanderos avatar May 14 '25 20:05 KevinMLanderos

Thanks Kevin, I think it shoud work now. It was just a small issue with the comments using #. I removed the, and added the expected output file. Seems to work as expected, but we need to wait to merge this after we merge the kinship module

chriswyatt1 avatar May 16 '25 01:05 chriswyatt1

WIP

When running nf-core modules test gemma/lmm, keep getting error highlighting midas module dependency, which should not be needed

You can ignore that, that's an unrelated issue that needs fixing

SPPearce avatar May 18 '25 10:05 SPPearce

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.

github-actions[bot] avatar Jul 13 '25 00:07 github-actions[bot]