modules icon indicating copy to clipboard operation
modules copied to clipboard

Update vcflib

Open saramonzon opened this issue 9 months ago • 4 comments

Updated vcflib modules to latest vcflib version

PR checklist

Related to https://github.com/nf-core/viralrecon/issues/467?issue=nf-core%7Cviralrecon%7C466

  • [x] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x] nf-core modules test <MODULE> --profile docker
      • [x] nf-core modules test <MODULE> --profile singularity
      • [x] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

saramonzon avatar Mar 25 '25 12:03 saramonzon

Nevermind, I found the problem. The version has to be updated manually in the main.nf

 def VERSION = '1.0.3' // WARN: Version information not provided by tool on CLI. Please update this string when bumping container versions.

That you should do and then update the snaps :)

And maybe open an Issue that they should add this to the tools functionality :)

famosab avatar Mar 25 '25 14:03 famosab

Nevermind, I found the problem. The version has to be updated manually in the main.nf

 def VERSION = '1.0.3' // WARN: Version information not provided by tool on CLI. Please update this string when bumping container versions.

That you should do and then update the snaps :)

And maybe open an Issue that they should add this to the tools functionality :)

Good catch! Didn't notice that on the main.nf. Thanks!

saramonzon avatar Mar 25 '25 16:03 saramonzon

Done! @famosab

saramonzon avatar Mar 25 '25 16:03 saramonzon

@famosab I think all done :)

saramonzon avatar Mar 25 '25 17:03 saramonzon