modules icon indicating copy to clipboard operation
modules copied to clipboard

Fixing FASTP in FASTQ_TRIM_FASTP_FASTQC

Open lucacozzuto opened this issue 9 months ago • 1 comments

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [X] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

lucacozzuto avatar Mar 25 '25 11:03 lucacozzuto

I'll try!

lucacozzuto avatar Mar 25 '25 12:03 lucacozzuto

Fixed in #8078

georgiakes avatar Mar 31 '25 13:03 georgiakes