modules icon indicating copy to clipboard operation
modules copied to clipboard

[MODULE] added new module polypolish/polish

Open ktrappe opened this issue 9 months ago • 1 comments

PR checklist

Closes https://github.com/nf-core/modules/issues/8024

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [x] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

ktrappe avatar Mar 25 '25 10:03 ktrappe

Thanks James! Hopefully I made all the right adjustments!

ktrappe avatar Mar 25 '25 13:03 ktrappe

@nf-core-bot fix linting

jfy133 avatar Mar 26 '25 05:03 jfy133

You need to update your snapshots @ktrappe , the new snapshot has the newly added debug channel whereas the original snapshot does not

jfy133 avatar Mar 26 '25 06:03 jfy133

@jfy133 I had to merge all the changes from the nf-core bot or rather those made by Prettier. There are also many changes for other modules.

ktrappe avatar Mar 26 '25 09:03 ktrappe

@jfy133 I created a new branch polypolish2 and local tests look good. Should I open another pr?

ktrappe avatar Mar 26 '25 12:03 ktrappe

Yes! Please open @ktrappe !

jfy133 avatar Mar 26 '25 12:03 jfy133

Abandoning for https://github.com/nf-core/modules/pull/8099

ktrappe avatar Mar 26 '25 12:03 ktrappe