modules icon indicating copy to clipboard operation
modules copied to clipboard

update module: need to create tests for getorganelle/fromreads

Open scorreard opened this issue 9 months ago • 3 comments

Is there an existing module for this?

  • [x] I have searched for the existing module

Is there an open PR for this?

  • [x] I have searched for existing PRs

Is there an open issue for this?

  • [x] I have searched for existing issues

Are you going to work on this?

  • [x] If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module

scorreard avatar Mar 25 '25 08:03 scorreard

The module getorganelle/fromreads doesn't have a test. This is creating issues for the following PR : https://github.com/nf-core/modules/pull/7978 meant to close this issue : https://github.com/nf-core/modules/issues/7910

scorreard avatar Mar 25 '25 08:03 scorreard

there used to be tests: https://github.com/nf-core/modules/pull/4484

maxulysse avatar Mar 25 '25 09:03 maxulysse

It seems that this tool need some updating / reviewing.

  1. Two fasta are generated and should be available as output (rather than only one of the fasta)
  2. The nf-test need to be checked as a log includes a time stemp

scorreard avatar Mar 25 '25 11:03 scorreard

I found a few more issues with it as well and denoted them here: https://github.com/nf-core/modules/issues/8879 (closing that because this issue tracks it already!)

famosab avatar Aug 11 '25 10:08 famosab