modules icon indicating copy to clipboard operation
modules copied to clipboard

issues with gprofiler2/gost

Open suzannejin opened this issue 11 months ago • 3 comments

Have you checked the docs?

Description of the bug

Several issues found for module gprofiler2/gost:

  1. Inconcistency between using --organism mmusculus or not Running with --organism mmusculus vs running with --organism null --gmt_file gprofiler_full_mmusculus.ENSG.gmt (gmt obtained by downloading from their website) will return different results.
  2. Fixing the database using set_base_url and then run gost on an archived database works locally but somehow gives error in the CI (https://github.com/nf-core/modules/actions/runs/13199316156/job/36850361811)
  3. By default, the module will not use the gmt_file given by user, if organism is specified. Maybe it should be the other way around?

Other issues that makes testing the module using nf-test difficult: 4. Fixing the database using set_base_url and then run gost on an archived database is extremely slow even for test dataset (about 8 min vs 30s when using the updated database). Not sure why, but it could be related to how gost interact with old archives.

suzannejin avatar Feb 07 '25 13:02 suzannejin

Are you planning to work on fixing these issues yourself? :)

famosab avatar Mar 13 '25 09:03 famosab

@famosab Hello! I am currently busy with other issues, so welcome if anybody wants to work on this :)

suzannejin avatar Mar 13 '25 10:03 suzannejin

@suzannejin One comment about your first issue

  1. Inconcistency between using --organism mmusculus or not Running with --organism mmusculus vs running with --organism null --gmt_file gprofiler_full_mmusculus.ENSG.gmt (gmt obtained by downloading from their website) will return different results.

When downloading the GMT file, they remove KEGG and Transfac (TF), due to licensing reasons. Are those the differences you are referring to? If you remove KEGG and TF from the list of the sources, is the result the same as the downloaded GMT file?

akaviaLab avatar Jun 24 '25 11:06 akaviaLab